Making clock dimm automatically, messes with program

Hi,

I just copied this project:
https://projecthub.arduino.cc/mdraber/tm1637-digital-clock-with-time-setup-and-alarm-functionality-b8d46c

And besides a ton of weird enters and spaces messing up the code, I got it working mostly. It doesn't beep the alarm, yet, so that is a side-question...

But the main question is this. I added a photoresistor and 1K voltage dividing resistor to get the thing to dimm when it's dark at night, and shine bright during the day. The sensor is at pin A6, I added code in lines 124, 125 and 126. But here's the funny bit. It only seems to work when the clock is in time set-up mode, and I can only go to the next setting after the light has changed significantly (hand over sensor and releas). So, my code it only read when in set-up mode and messes with the code when it is active. And I don't have a clue, why. Do you?

Here's the code:

// Mario's Ideas
// TM1637 Digital Clock with Setup and Alarm Functionality

#include <Arduino.h>
#include <TM1637Display.h>
#include <virtuabotixRTC.h> //

// RTC module declaration
// PINS CLK, DAT, RST
virtuabotixRTC myRTC(A1,A2,A3);

// Variables to store previous values read off RTC module
int minutes;
int hours;
// Variables to store the time at which Alarm should go off 
int Alarm_minutes=05;
int Alarm_hours=18;
uint8_t Blank[] = {0x0};
int POSITION=0;

//Table to store 4 digits, used in time and Alarm setup procedure
int digits[3];
int interval=0;

int lightSens = A6;
int brightness;


#define Alarm 9 // Button to switch alarm mode on or off
#define Buzer 13
#define Led 8


//Statuses
boolean Alarm_set=false;
boolean Alarm_in_progress=false;
boolean Setup_on= false;

// 4digit display connection pins (Digital Pins)
#define CLK 4
#define DIO 5


// 4 digit display declaration
TM1637Display clock(CLK, DIO);

void setup() {
  
 attachInterrupt(digitalPinToInterrupt(2),
  Press_A_Button,RISING);
 attachInterrupt(digitalPinToInterrupt(3), Press_B_Button,RISING);

  pinMode(Alarm, INPUT);
  pinMode(Buzer, OUTPUT);
  pinMode(Led, OUTPUT);
  digitalWrite(Buzer,LOW);
  clock.setBrightness(7);  // was 0x0f
  Serial.begin(9600);
}

void
  Press_A_Button(){
  if (interval>3){
    if (Setup_on==false){
      Setup_on=true;

      if (Alarm_set==true){
        digits[0]= (int)Alarm_hours/10;
        digits[1]= Alarm_hours-((int)Alarm_hours/10)*10;
        digits[2]= (int)Alarm_minutes/10;
        digits[3]= Alarm_minutes-((int)Alarm_minutes/10)*10; 
      } 
      else
  {
        digits[0]= (int)myRTC.hours/10;
        digits[1]= myRTC.hours-((int)myRTC.hours/10)*10;
        digits[2]= (int)myRTC.minutes/10;
        digits[3]= myRTC.minutes-((int)myRTC.minutes/10)*10;

      }
    }
    else{
      POSITION++;
      if (POSITION==4){

        if (Alarm_set==true){
          Alarm_minutes=digits[3]+digits[2]*10;
          Alarm_hours=digits[1]+digits[0]*10;
        } 
        else {

          myRTC.setDS1302Time( 0, digits[3]+digits[2]*10,
          digits[1]+digits[0]*10,myRTC.dayofweek,
          myRTC.dayofmonth, myRTC.month, myRTC.year);
          clock.showNumberDec(digits[0],false,1,0);
          clock.showNumberDec(digits[1],false,1,1);
          clock.showNumberDec(digits[2],false,1,2);
          clock.showNumberDec(digits[3],false,1,3);
        }
        POSITION=0;
        Setup_on=false;
      }
    }
  }
  interval=0;
}

void
  Press_B_Button(){
  if (interval>3){
    if(Setup_on){
      digits[POSITION]=digits[POSITION]+1;
      if (POSITION==0 and digits[POSITION]==3) digits[POSITION]=0;
      if (POSITION!=0 and digits[POSITION]==10) digits[POSITION]=0;
      interval=0;
    } 

  }
  interval=0;
}

void loop() {  

brightness = analogRead(lightSens);
Serial.println(brightness);
clock.setBrightness(map(brightness,80,600,1,7)); // 80 is dark, 600 is light  

if (digitalRead(Alarm)==HIGH and Alarm_set==false ){
    if (interval>30){
      digitalWrite(Led,HIGH);
      Alarm_set=true;
      delay(300);
    }
  } else{
    if (digitalRead(Alarm)==HIGH and Alarm_set==true){
      if (interval>30){
      Alarm_set=false;
      Alarm_in_progress=false;
      digitalWrite(Led,LOW);
      delay(300);
    }
   }
 }
 myRTC.updateTime();

 if (Setup_on==true){
    clock.showNumberDec(digits[0],false,1,0);
    clock.showNumberDec(digits[1],false,1,1);
    clock.showNumberDec(digits[2],false,1,2);
    clock.showNumberDec(digits[3],false,1,3);
    delay(200);
    clock.setSegments(Blank,1,POSITION);  
    delay(200);
    clock.showNumberDec(digits[0],false,1,0);
    clock.showNumberDec(digits[1],false,1,1);
    clock.showNumberDec(digits[2],false,1,2);
    clock.showNumberDec(digits[3],false,1,3);
  }
 else{
   if (myRTC.minutes==Alarm_minutes
  and myRTC.hours==Alarm_hours and Alarm_set==true and Setup_on==false){
    Alarm_in_progress=true;

   }

   if (Alarm_in_progress){
     digitalWrite(Buzer,HIGH);
     delay(1000);
     digitalWrite(Buzer,LOW);
     delay(1000);
   } 
   
 if (myRTC.minutes!=minutes){

    
   clock.showNumberDecEx((int)myRTC.hours/10*1000+(myRTC.hours-((int)myRTC.hours/10)*10)*100+
  (int)myRTC.minutes/10*10+myRTC.minutes-((int)myRTC.minutes/10)*10, (0x80 >> 1), true);
   minutes=myRTC.minutes;
   hours=myRTC.hours;
   
   }

  }
 if (interval<200) interval++;


}

My lines are at the beginning of the void loop section. Please teach me what is happening, and how to make it work properly.

Cheers,

Hugo

2 posts - 2 participants

Read full topic